Skip to content

Commit

Permalink
openvswitch: Fix memory leak.
Browse files Browse the repository at this point in the history
Need to free memory in case of sample action error.

Introduced by commit 651887b ("openvswitch: Sample
action without side effects").

Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
  • Loading branch information
Pravin B Shelar committed Nov 14, 2014
1 parent b23dc5a commit ab64f16
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions net/openvswitch/actions.c
Original file line number Diff line number Diff line change
Expand Up @@ -722,8 +722,6 @@ static int do_execute_actions(struct datapath *dp, struct sk_buff *skb,

case OVS_ACTION_ATTR_SAMPLE:
err = sample(dp, skb, key, a);
if (unlikely(err)) /* skb already freed. */
return err;
break;
}

Expand Down

0 comments on commit ab64f16

Please sign in to comment.