Skip to content

Commit

Permalink
quota: Fix possible GPF due to uninitialised pointers
Browse files Browse the repository at this point in the history
When dqget() in __dquot_initialize() fails e.g. due to IO error,
__dquot_initialize() will pass an array of uninitialized pointers to
dqput_all() and thus can lead to deference of random data. Fix the
problem by properly initializing the array.

CC: stable@vger.kernel.org
Signed-off-by: Nikolay Borisov <kernel@kyup.com>
Signed-off-by: Jan Kara <jack@suse.cz>
  • Loading branch information
Nikolay Borisov authored and Jan Kara committed Mar 3, 2016
1 parent 6332b9b commit ab73ef4
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions fs/quota/dquot.c
Original file line number Diff line number Diff line change
Expand Up @@ -1410,7 +1410,7 @@ static int dquot_active(const struct inode *inode)
static int __dquot_initialize(struct inode *inode, int type)
{
int cnt, init_needed = 0;
struct dquot **dquots, *got[MAXQUOTAS];
struct dquot **dquots, *got[MAXQUOTAS] = {};
struct super_block *sb = inode->i_sb;
qsize_t rsv;
int ret = 0;
Expand All @@ -1427,7 +1427,6 @@ static int __dquot_initialize(struct inode *inode, int type)
int rc;
struct dquot *dquot;

got[cnt] = NULL;
if (type != -1 && cnt != type)
continue;
/*
Expand Down

0 comments on commit ab73ef4

Please sign in to comment.