Skip to content

Commit

Permalink
firmware: Drop unused pages field from struct firmware
Browse files Browse the repository at this point in the history
The struct firmware contains a page table pointer that was used only
internally in the past.  Since the actual page tables are referred
from struct fw_priv and should be never from struct firmware, we can
drop this unused field gracefully.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Luis Chamberlain <mcgrof@kernel.org>
Link: https://lore.kernel.org/r/20200415164500.28749-1-tiwai@suse.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Takashi Iwai authored and Greg Kroah-Hartman committed Apr 17, 2020
1 parent 8f3d9f3 commit ab7c1e1
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
3 changes: 0 additions & 3 deletions drivers/base/firmware_loader/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -548,9 +548,6 @@ static void firmware_free_data(const struct firmware *fw)
static void fw_set_page_data(struct fw_priv *fw_priv, struct firmware *fw)
{
fw->priv = fw_priv;
#ifdef CONFIG_FW_LOADER_USER_HELPER
fw->pages = fw_priv->pages;
#endif
fw->size = fw_priv->size;
fw->data = fw_priv->data;

Expand Down
1 change: 0 additions & 1 deletion include/linux/firmware.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
struct firmware {
size_t size;
const u8 *data;
struct page **pages;

/* firmware loader private fields */
void *priv;
Expand Down

0 comments on commit ab7c1e1

Please sign in to comment.