Skip to content

Commit

Permalink
liquidio: fix hang when re-binding VF host drv after running DPDK VF …
Browse files Browse the repository at this point in the history
…driver

When configuring SLI_PKTn_OUTPUT_CONTROL, VF driver was assuming that IPTR
mode was disabled by reset, which was not true.  Since DPDK driver had
set IPTR mode previously, the VF driver (which uses buf-ptr-only mode) was
not properly handling DROQ packets (i.e. it saw zero-length packets).

This represented an invalid hardware configuration which the driver could
not handle.

Signed-off-by: Rick Farrington <ricardo.farrington@cavium.com>
Signed-off-by: Felix Manlunas <felix.manlunas@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Rick Farrington authored and David S. Miller committed Jul 16, 2018
1 parent 7e2bc7f commit ac13d6d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.c
Original file line number Diff line number Diff line change
Expand Up @@ -493,6 +493,9 @@ static void cn23xx_pf_setup_global_output_regs(struct octeon_device *oct)
for (q_no = srn; q_no < ern; q_no++) {
reg_val = octeon_read_csr(oct, CN23XX_SLI_OQ_PKT_CONTROL(q_no));

/* clear IPTR */
reg_val &= ~CN23XX_PKT_OUTPUT_CTL_IPTR;

/* set DPTR */
reg_val |= CN23XX_PKT_OUTPUT_CTL_DPTR;

Expand Down
3 changes: 3 additions & 0 deletions drivers/net/ethernet/cavium/liquidio/cn23xx_vf_device.c
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,9 @@ static void cn23xx_vf_setup_global_output_regs(struct octeon_device *oct)
reg_val =
octeon_read_csr(oct, CN23XX_VF_SLI_OQ_PKT_CONTROL(q_no));

/* clear IPTR */
reg_val &= ~CN23XX_PKT_OUTPUT_CTL_IPTR;

/* set DPTR */
reg_val |= CN23XX_PKT_OUTPUT_CTL_DPTR;

Expand Down

0 comments on commit ac13d6d

Please sign in to comment.