Skip to content

Commit

Permalink
x86/vdso: Set VM_MAYREAD for the vvar vma
Browse files Browse the repository at this point in the history
The VVAR area can, obviously, be read; that is kind of the point.

AFAIK this has no effect whatsoever unless x86 suddenly turns into a
nommu architecture.  Nonetheless, not setting it is suspicious.

Reported-by: Nathan Lynch <Nathan_Lynch@mentor.com>
Signed-off-by: Andy Lutomirski <luto@amacapital.net>
Link: http://lkml.kernel.org/r/e4c8bf4bc2725bda22c4a4b7d0c82adcd8f8d9b8.1406330779.git.luto@amacapital.net
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
  • Loading branch information
Andy Lutomirski authored and H. Peter Anvin committed Jul 25, 2014
1 parent da861e1 commit ac37983
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/x86/vdso/vma.c
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ static int map_vdso(const struct vdso_image *image, bool calculate_addr)
vma = _install_special_mapping(mm,
addr,
-image->sym_vvar_start,
VM_READ,
VM_READ|VM_MAYREAD,
&vvar_mapping);

if (IS_ERR(vma)) {
Expand Down

0 comments on commit ac37983

Please sign in to comment.