Skip to content

Commit

Permalink
ASoC: soc-cache: Return -ENOSYS instead of -EINVAL
Browse files Browse the repository at this point in the history
These functions fail with -EINVAL if the corresponding callbacks
are not implemented.  Change them to return -ENOSYS as it is more
appropriate for unimplemented callbacks.

Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Acked-by: Liam Girdwood <lrg@ti.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
  • Loading branch information
Dimitris Papastamos authored and Mark Brown committed Mar 26, 2011
1 parent 30539a1 commit acd6145
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions sound/soc/soc-cache.c
Original file line number Diff line number Diff line change
Expand Up @@ -1295,7 +1295,7 @@ int snd_soc_cache_init(struct snd_soc_codec *codec)
codec->cache_ops->name, codec->name);
return codec->cache_ops->init(codec);
}
return -EINVAL;
return -ENOSYS;
}

/*
Expand All @@ -1310,7 +1310,7 @@ int snd_soc_cache_exit(struct snd_soc_codec *codec)
codec->cache_ops->name, codec->name);
return codec->cache_ops->exit(codec);
}
return -EINVAL;
return -ENOSYS;
}

/**
Expand All @@ -1334,7 +1334,7 @@ int snd_soc_cache_read(struct snd_soc_codec *codec,
}

mutex_unlock(&codec->cache_rw_mutex);
return -EINVAL;
return -ENOSYS;
}
EXPORT_SYMBOL_GPL(snd_soc_cache_read);

Expand All @@ -1359,7 +1359,7 @@ int snd_soc_cache_write(struct snd_soc_codec *codec,
}

mutex_unlock(&codec->cache_rw_mutex);
return -EINVAL;
return -ENOSYS;
}
EXPORT_SYMBOL_GPL(snd_soc_cache_write);

Expand All @@ -1382,7 +1382,7 @@ int snd_soc_cache_sync(struct snd_soc_codec *codec)
}

if (!codec->cache_ops || !codec->cache_ops->sync)
return -EINVAL;
return -ENOSYS;

if (codec->cache_ops->name)
name = codec->cache_ops->name;
Expand Down

0 comments on commit acd6145

Please sign in to comment.