Skip to content

Commit

Permalink
media: Revert "media: rkisp1: Drop IRQF_SHARED"
Browse files Browse the repository at this point in the history
commit a107d64 upstream.

This reverts commit 85d2a31.

The rkisp1 does share interrupt lines on some platforms, after all. Thus
we need to revert this, and implement a fix for the rkisp1 shared irq
handling in a follow-up patch.

Closes: https://lore.kernel.org/all/87o7eo8vym.fsf@gmail.com/
Link: https://lore.kernel.org/r/20231218-rkisp-shirq-fix-v1-1-173007628248@ideasonboard.com

Reported-by: Mikhail Rudenko <mike.rudenko@gmail.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Tomi Valkeinen authored and Greg Kroah-Hartman committed Feb 23, 2024
1 parent 9ae312f commit acff71e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@ static int rkisp1_probe(struct platform_device *pdev)
if (irq < 0)
return irq;

ret = devm_request_irq(dev, irq, rkisp1_isr, 0,
ret = devm_request_irq(dev, irq, rkisp1_isr, IRQF_SHARED,
dev_driver_string(dev), dev);
if (ret) {
dev_err(dev, "request irq failed: %d\n", ret);
Expand Down

0 comments on commit acff71e

Please sign in to comment.