Skip to content

Commit

Permalink
selinux: Use kcalloc() in policydb_index()
Browse files Browse the repository at this point in the history
Multiplications for the size determination of memory allocations
indicated that array data structures should be processed.
Thus use the corresponding function "kcalloc".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Paul Moore <paul@paul-moore.com>
  • Loading branch information
Markus Elfring authored and Paul Moore committed Mar 23, 2017
1 parent cb8d21e commit ad10a10
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions security/selinux/ss/policydb.c
Original file line number Diff line number Diff line change
Expand Up @@ -540,23 +540,23 @@ static int policydb_index(struct policydb *p)
#endif

rc = -ENOMEM;
p->class_val_to_struct =
kzalloc(p->p_classes.nprim * sizeof(*(p->class_val_to_struct)),
GFP_KERNEL);
p->class_val_to_struct = kcalloc(p->p_classes.nprim,
sizeof(*p->class_val_to_struct),
GFP_KERNEL);
if (!p->class_val_to_struct)
goto out;

rc = -ENOMEM;
p->role_val_to_struct =
kzalloc(p->p_roles.nprim * sizeof(*(p->role_val_to_struct)),
GFP_KERNEL);
p->role_val_to_struct = kcalloc(p->p_roles.nprim,
sizeof(*p->role_val_to_struct),
GFP_KERNEL);
if (!p->role_val_to_struct)
goto out;

rc = -ENOMEM;
p->user_val_to_struct =
kzalloc(p->p_users.nprim * sizeof(*(p->user_val_to_struct)),
GFP_KERNEL);
p->user_val_to_struct = kcalloc(p->p_users.nprim,
sizeof(*p->user_val_to_struct),
GFP_KERNEL);
if (!p->user_val_to_struct)
goto out;

Expand Down

0 comments on commit ad10a10

Please sign in to comment.