Skip to content

Commit

Permalink
wlcore/wl12xx/wl18xx: move lower driver debugfs to a subdir
Browse files Browse the repository at this point in the history
Instead of adding more files from the lower drivers into the same
directory in debugfs as wlcore, we now add a subdirectory for the
lower driver.  This makes things a bit easier, because we can quickly
see where the debugfs entry is implemented and what is specific to the
lower driver.

Signed-off-by: Luciano Coelho <coelho@ti.com>
Signed-off-by: Arik Nemtsov <arik@wizery.com>
  • Loading branch information
Luciano Coelho committed Jun 5, 2012
1 parent 7b03c30 commit ad62d81
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 16 deletions.
10 changes: 8 additions & 2 deletions drivers/net/wireless/ti/wl12xx/debugfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -126,9 +126,15 @@ int wl12xx_debugfs_add_files(struct wl1271 *wl,
struct dentry *rootdir)
{
int ret = 0;
struct dentry *entry, *stats;
struct dentry *entry, *stats, *moddir;

stats = debugfs_create_dir("wl12xx_fw_stats", rootdir);
moddir = debugfs_create_dir(KBUILD_MODNAME, rootdir);
if (!moddir || IS_ERR(moddir)) {
entry = moddir;
goto err;
}

stats = debugfs_create_dir("fw_stats", moddir);
if (!stats || IS_ERR(stats)) {
entry = stats;
goto err;
Expand Down
7 changes: 1 addition & 6 deletions drivers/net/wireless/ti/wl12xx/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -1360,11 +1360,6 @@ static int wl12xx_plt_init(struct wl1271 *wl)
return ret;
}

static int wl12xx_debugfs_init(struct wl1271 *wl, struct dentry *rootdir)
{
return wl12xx_debugfs_add_files(wl, rootdir);
}

static struct wlcore_ops wl12xx_ops = {
.identify_chip = wl12xx_identify_chip,
.identify_fw = wl12xx_identify_fw,
Expand All @@ -1387,7 +1382,7 @@ static struct wlcore_ops wl12xx_ops = {
.set_tx_desc_csum = wl12xx_set_tx_desc_csum,
.set_rx_csum = NULL,
.ap_get_mimo_wide_rate_mask = NULL,
.debugfs_init = wl12xx_debugfs_init,
.debugfs_init = wl12xx_debugfs_add_files,
};

static struct ieee80211_sta_ht_cap wl12xx_ht_cap = {
Expand Down
10 changes: 8 additions & 2 deletions drivers/net/wireless/ti/wl18xx/debugfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -181,9 +181,15 @@ int wl18xx_debugfs_add_files(struct wl1271 *wl,
struct dentry *rootdir)
{
int ret = 0;
struct dentry *entry, *stats;
struct dentry *entry, *stats, *moddir;

stats = debugfs_create_dir("wl18xx_fw_stats", rootdir);
moddir = debugfs_create_dir(KBUILD_MODNAME, rootdir);
if (!moddir || IS_ERR(moddir)) {
entry = moddir;
goto err;
}

stats = debugfs_create_dir("fw_stats", moddir);
if (!stats || IS_ERR(stats)) {
entry = stats;
goto err;
Expand Down
7 changes: 1 addition & 6 deletions drivers/net/wireless/ti/wl18xx/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -1022,11 +1022,6 @@ static void wl18xx_get_mac(struct wl1271 *wl)
wlcore_set_partition(wl, &wl->ptable[PART_DOWN]);
}

static int wl18xx_debugfs_init(struct wl1271 *wl, struct dentry *rootdir)
{
return wl18xx_debugfs_add_files(wl, rootdir);
}

static int wl18xx_handle_static_data(struct wl1271 *wl,
struct wl1271_static_data *static_data)
{
Expand Down Expand Up @@ -1058,7 +1053,7 @@ static struct wlcore_ops wl18xx_ops = {
.sta_get_ap_rate_mask = wl18xx_sta_get_ap_rate_mask,
.ap_get_mimo_wide_rate_mask = wl18xx_ap_get_mimo_wide_rate_mask,
.get_mac = wl18xx_get_mac,
.debugfs_init = wl18xx_debugfs_init,
.debugfs_init = wl18xx_debugfs_add_files,
.handle_static_data = wl18xx_handle_static_data,
};

Expand Down

0 comments on commit ad62d81

Please sign in to comment.