Skip to content

Commit

Permalink
staging: sm750fb: Remove typedef
Browse files Browse the repository at this point in the history
Change typedef enum to enum and ensure compatibility of change. Issue
found with checkpatch.

Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Nishka Dasgupta authored and Greg Kroah-Hartman committed Mar 19, 2018
1 parent 8161481 commit ad7d95e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
2 changes: 1 addition & 1 deletion drivers/staging/sm750fb/ddk750_display.c
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ static void swPanelPowerSequence(int disp, int delay)
primary_wait_vertical_sync(delay);
}

void ddk750_setLogicalDispOut(disp_output_t output)
void ddk750_setLogicalDispOut(enum disp_output output)
{
unsigned int reg;

Expand Down
7 changes: 3 additions & 4 deletions drivers/staging/sm750fb/ddk750_display.h
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
* LCD1 means panel path TFT1 & panel path DVI (so enable DAC)
* CRT means crt path DSUB
*/
typedef enum _disp_output_t {
enum disp_output {
do_LCD1_PRI = PNL_2_PRI | PRI_TP_ON | PNL_SEQ_ON | DAC_ON,
do_LCD1_SEC = PNL_2_SEC | SEC_TP_ON | PNL_SEQ_ON | DAC_ON,
do_LCD2_PRI = CRT_2_PRI | PRI_TP_ON | DUAL_TFT_ON,
Expand All @@ -100,9 +100,8 @@ typedef enum _disp_output_t {
*/
do_CRT_PRI = CRT_2_PRI | PRI_TP_ON | DPMS_ON | DAC_ON,
do_CRT_SEC = CRT_2_SEC | SEC_TP_ON | DPMS_ON | DAC_ON,
}
disp_output_t;
};

void ddk750_setLogicalDispOut(disp_output_t output);
void ddk750_setLogicalDispOut(enum disp_output output);

#endif
2 changes: 1 addition & 1 deletion drivers/staging/sm750fb/sm750_hw.c
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ int hw_sm750_output_setMode(struct lynxfb_output *output,
struct fb_fix_screeninfo *fix)
{
int ret;
disp_output_t disp_set;
enum disp_output disp_set;
int channel;

ret = 0;
Expand Down

0 comments on commit ad7d95e

Please sign in to comment.