Skip to content

Commit

Permalink
drm/etnaviv: Fix a leak in submit_pin_objects()
Browse files Browse the repository at this point in the history
If the mapping address is wrong then we have to release the reference to
it before returning -EINVAL.

Fixes: 088880d ("drm/etnaviv: implement softpin")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
  • Loading branch information
Dan Carpenter authored and Lucas Stach committed May 19, 2020
1 parent 40b697e commit ad99cb5
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
Original file line number Diff line number Diff line change
Expand Up @@ -238,8 +238,10 @@ static int submit_pin_objects(struct etnaviv_gem_submit *submit)
}

if ((submit->flags & ETNA_SUBMIT_SOFTPIN) &&
submit->bos[i].va != mapping->iova)
submit->bos[i].va != mapping->iova) {
etnaviv_gem_mapping_unreference(mapping);
return -EINVAL;
}

atomic_inc(&etnaviv_obj->gpu_active);

Expand Down

0 comments on commit ad99cb5

Please sign in to comment.