Skip to content

Commit

Permalink
Merge tag 'parisc-misc' of git://git.kernel.org/pub/scm/linux/kernel/…
Browse files Browse the repository at this point in the history
…git/jejb/parisc-2.6

Pull PARISC misc updates from James Bottomley:
 "This is a couple of minor updates (fixing lws futex locking and
  removing some obsolete cpu_*_map calls)."

* tag 'parisc-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/parisc-2.6:
  [PARISC] remove references to cpu_*_map.
  [PARISC] futex: Use same lock set as lws calls
  • Loading branch information
Linus Torvalds committed Mar 31, 2012
2 parents a75ee6e + 7ec6118 commit adb3b1f
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 6 deletions.
31 changes: 27 additions & 4 deletions arch/parisc/include/asm/futex.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,29 @@
#include <asm/atomic.h>
#include <asm/errno.h>

/* The following has to match the LWS code in syscall.S. We have
sixteen four-word locks. */

static inline void
_futex_spin_lock_irqsave(u32 __user *uaddr, unsigned long int *flags)
{
extern u32 lws_lock_start[];
long index = ((long)uaddr & 0xf0) >> 2;
arch_spinlock_t *s = (arch_spinlock_t *)&lws_lock_start[index];
local_irq_save(*flags);
arch_spin_lock(s);
}

static inline void
_futex_spin_unlock_irqrestore(u32 __user *uaddr, unsigned long int *flags)
{
extern u32 lws_lock_start[];
long index = ((long)uaddr & 0xf0) >> 2;
arch_spinlock_t *s = (arch_spinlock_t *)&lws_lock_start[index];
arch_spin_unlock(s);
local_irq_restore(*flags);
}

static inline int
futex_atomic_op_inuser (int encoded_op, u32 __user *uaddr)
{
Expand All @@ -26,7 +49,7 @@ futex_atomic_op_inuser (int encoded_op, u32 __user *uaddr)

pagefault_disable();

_atomic_spin_lock_irqsave(uaddr, flags);
_futex_spin_lock_irqsave(uaddr, &flags);

switch (op) {
case FUTEX_OP_SET:
Expand Down Expand Up @@ -71,7 +94,7 @@ futex_atomic_op_inuser (int encoded_op, u32 __user *uaddr)
ret = -ENOSYS;
}

_atomic_spin_unlock_irqrestore(uaddr, flags);
_futex_spin_unlock_irqrestore(uaddr, &flags);

pagefault_enable();

Expand Down Expand Up @@ -113,7 +136,7 @@ futex_atomic_cmpxchg_inatomic(u32 *uval, u32 __user *uaddr,
* address. This should scale to a couple of CPUs.
*/

_atomic_spin_lock_irqsave(uaddr, flags);
_futex_spin_lock_irqsave(uaddr, &flags);

ret = get_user(val, uaddr);

Expand All @@ -122,7 +145,7 @@ futex_atomic_cmpxchg_inatomic(u32 *uval, u32 __user *uaddr,

*uval = val;

_atomic_spin_unlock_irqrestore(uaddr, flags);
_futex_spin_unlock_irqrestore(uaddr, &flags);

return ret;
}
Expand Down
3 changes: 1 addition & 2 deletions arch/parisc/kernel/smp.c
Original file line number Diff line number Diff line change
Expand Up @@ -290,8 +290,7 @@ smp_cpu_init(int cpunum)
mb();

/* Well, support 2.4 linux scheme as well. */
if (cpu_isset(cpunum, cpu_online_map))
{
if (cpu_online(cpunum)) {
extern void machine_halt(void); /* arch/parisc.../process.c */

printk(KERN_CRIT "CPU#%d already initialized!\n", cpunum);
Expand Down

0 comments on commit adb3b1f

Please sign in to comment.