Skip to content

Commit

Permalink
nohz: disable tick_nohz_kick_tick() for now
Browse files Browse the repository at this point in the history
Impact: nohz powersavings and wakeup regression

commit fb02fbc (NOHZ: restart tick
device from irq_enter()) causes a serious wakeup regression.

While the patch is correct it does not take into account that spurious
wakeups happen on x86. A fix for this issue is available, but we just
revert to the .27 behaviour and let long running softirqs screw
themself.

Disable it for now.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Thomas Gleixner authored and Thomas Gleixner committed Nov 10, 2008
1 parent ee5f80a commit ae99286
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions kernel/time/tick-sched.c
Original file line number Diff line number Diff line change
Expand Up @@ -568,6 +568,9 @@ static void tick_nohz_switch_to_nohz(void)
*/
static void tick_nohz_kick_tick(int cpu)
{
#if 0
/* Switch back to 2.6.27 behaviour */

struct tick_sched *ts = &per_cpu(tick_cpu_sched, cpu);
ktime_t delta, now;

Expand All @@ -584,6 +587,7 @@ static void tick_nohz_kick_tick(int cpu)
return;

tick_nohz_restart(ts, now);
#endif
}

#else
Expand Down

0 comments on commit ae99286

Please sign in to comment.