Skip to content

Commit

Permalink
lightnvm: change max_phys_sect to uint
Browse files Browse the repository at this point in the history
The max_phys_sect variable is defined as a char. We do a boundary check
to maximally allow 256 physical page descriptors per command. As we are
not indexing from zero. This expression is always false. Bump the
max_phys_sect to an unsigned int to support the range check.

Signed-off-by: Matias Bjørling <m@bjorling.me>
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Jens Axboe <axboe@fb.com>
  • Loading branch information
Matias Bjørling authored and Jens Axboe committed Nov 16, 2015
1 parent 4ead1a2 commit aedf17f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion include/linux/lightnvm.h
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ struct nvm_dev_ops {
nvm_dev_dma_alloc_fn *dev_dma_alloc;
nvm_dev_dma_free_fn *dev_dma_free;

uint8_t max_phys_sect;
unsigned int max_phys_sect;
};

struct nvm_lun {
Expand Down

0 comments on commit aedf17f

Please sign in to comment.