Skip to content

Commit

Permalink
Merge branch 'efi-urgent-for-linus' of git://git.kernel.org/pub/scm/l…
Browse files Browse the repository at this point in the history
…inux/kernel/git/tip/tip

Pull EFI fixes from Ingo Molnar:
 "Two EFI fixes: a quirk for weird systabs, plus add more robust error
  handling in the old 1:1 mapping code"

* 'efi-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
  efi: Allow the number of EFI configuration tables entries to be zero
  efi/x86/Add missing error handling to old_memmap 1:1 mapping code
  • Loading branch information
Linus Torvalds committed Jun 2, 2019
2 parents 4fb5741 + 88447c5 commit af04245
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 3 deletions.
2 changes: 2 additions & 0 deletions arch/x86/platform/efi/efi.c
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ static efi_status_t __init phys_efi_set_virtual_address_map(
pgd_t *save_pgd;

save_pgd = efi_call_phys_prolog();
if (!save_pgd)
return EFI_ABORTED;

/* Disable interrupts around EFI calls: */
local_irq_save(flags);
Expand Down
9 changes: 6 additions & 3 deletions arch/x86/platform/efi/efi_64.c
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,15 @@ pgd_t * __init efi_call_phys_prolog(void)

if (!efi_enabled(EFI_OLD_MEMMAP)) {
efi_switch_mm(&efi_mm);
return NULL;
return efi_mm.pgd;
}

early_code_mapping_set_exec(1);

n_pgds = DIV_ROUND_UP((max_pfn << PAGE_SHIFT), PGDIR_SIZE);
save_pgd = kmalloc_array(n_pgds, sizeof(*save_pgd), GFP_KERNEL);
if (!save_pgd)
return NULL;

/*
* Build 1:1 identity mapping for efi=old_map usage. Note that
Expand Down Expand Up @@ -138,10 +140,11 @@ pgd_t * __init efi_call_phys_prolog(void)
pgd_offset_k(pgd * PGDIR_SIZE)->pgd &= ~_PAGE_NX;
}

out:
__flush_tlb_all();

return save_pgd;
out:
efi_call_phys_epilog(save_pgd);
return NULL;
}

void __init efi_call_phys_epilog(pgd_t *save_pgd)
Expand Down
3 changes: 3 additions & 0 deletions arch/x86/platform/efi/quirks.c
Original file line number Diff line number Diff line change
Expand Up @@ -513,6 +513,9 @@ int __init efi_reuse_config(u64 tables, int nr_tables)
void *p, *tablep;
struct efi_setup_data *data;

if (nr_tables == 0)
return 0;

if (!efi_setup)
return 0;

Expand Down
3 changes: 3 additions & 0 deletions drivers/firmware/efi/efi.c
Original file line number Diff line number Diff line change
Expand Up @@ -636,6 +636,9 @@ int __init efi_config_init(efi_config_table_type_t *arch_tables)
void *config_tables;
int sz, ret;

if (efi.systab->nr_tables == 0)
return 0;

if (efi_enabled(EFI_64BIT))
sz = sizeof(efi_config_table_64_t);
else
Expand Down

0 comments on commit af04245

Please sign in to comment.