Skip to content

Commit

Permalink
perf c2c report: Add --show-all option
Browse files Browse the repository at this point in the history
Normally we limit the main list to contain only entries with HITM %
value > 0.0005, but it might be useful to display all captured entries.
Adding --show-all option for that.

Requested-and-Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Joe Mario <jmario@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/n/tip-nokgjdwikbegec5jzj4mxhqc@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Jiri Olsa authored and Arnaldo Carvalho de Melo committed Oct 21, 2016
1 parent 18f278d commit af09b2d
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
3 changes: 3 additions & 0 deletions tools/perf/Documentation/perf-c2c.txt
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,9 @@ REPORT OPTIONS
--no-source::
Do not display Source:Line column.

--show-all::
Show all captured HITM lines, with no regard to HITM % 0.0005 limit.

C2C RECORD
----------
The perf c2c record command setup options related to HITM cacheline analysis
Expand Down
7 changes: 5 additions & 2 deletions tools/perf/builtin-c2c.c
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ struct perf_c2c {
int node_info;

bool show_src;
bool show_all;
bool use_stdio;
bool stats_only;
bool symbol_full;
Expand Down Expand Up @@ -1773,8 +1774,8 @@ static bool he__display(struct hist_entry *he, struct c2c_stats *stats)
struct c2c_hist_entry *c2c_he;
double ld_dist;

/* XXX Disabled for now, till we get a command line switch to control this */
return true;
if (c2c.show_all)
return true;

c2c_he = container_of(he, struct c2c_hist_entry, he);

Expand Down Expand Up @@ -2513,6 +2514,8 @@ static int perf_c2c__report(int argc, const char **argv)
"Display full length of symbols"),
OPT_BOOLEAN(0, "no-source", &no_source,
"Do not display Source Line column"),
OPT_BOOLEAN(0, "show-all", &c2c.show_all,
"Show all captured HITM lines."),
OPT_CALLBACK_DEFAULT('g', "call-graph", &callchain_param,
"print_type,threshold[,print_limit],order,sort_key[,branch],value",
callchain_help, &parse_callchain_opt,
Expand Down

0 comments on commit af09b2d

Please sign in to comment.