Skip to content

Commit

Permalink
async_tx: kill needless module_{init|exit}
Browse files Browse the repository at this point in the history
If module_init and module_exit are nops then neither need to be defined.

[ Impact: pure cleanup ]

Reviewed-by: Andre Noll <maan@systemlinux.org>
Acked-by: Maciej Sosnowski <maciej.sosnowski@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
  • Loading branch information
Dan Williams committed Aug 30, 2009
1 parent ad283ea commit af1f951
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 40 deletions.
13 changes: 0 additions & 13 deletions crypto/async_tx/async_memcpy.c
Original file line number Diff line number Diff line change
Expand Up @@ -90,19 +90,6 @@ async_memcpy(struct page *dest, struct page *src, unsigned int dest_offset,
}
EXPORT_SYMBOL_GPL(async_memcpy);

static int __init async_memcpy_init(void)
{
return 0;
}

static void __exit async_memcpy_exit(void)
{
do { } while (0);
}

module_init(async_memcpy_init);
module_exit(async_memcpy_exit);

MODULE_AUTHOR("Intel Corporation");
MODULE_DESCRIPTION("asynchronous memcpy api");
MODULE_LICENSE("GPL");
13 changes: 0 additions & 13 deletions crypto/async_tx/async_memset.c
Original file line number Diff line number Diff line change
Expand Up @@ -80,19 +80,6 @@ async_memset(struct page *dest, int val, unsigned int offset, size_t len,
}
EXPORT_SYMBOL_GPL(async_memset);

static int __init async_memset_init(void)
{
return 0;
}

static void __exit async_memset_exit(void)
{
do { } while (0);
}

module_init(async_memset_init);
module_exit(async_memset_exit);

MODULE_AUTHOR("Intel Corporation");
MODULE_DESCRIPTION("asynchronous memset api");
MODULE_LICENSE("GPL");
17 changes: 3 additions & 14 deletions crypto/async_tx/async_tx.c
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ static void __exit async_tx_exit(void)
async_dmaengine_put();
}

module_init(async_tx_init);
module_exit(async_tx_exit);

/**
* __async_tx_find_channel - find a channel to carry out the operation or let
* the transaction execute synchronously
Expand All @@ -61,17 +64,6 @@ __async_tx_find_channel(struct async_submit_ctl *submit,
return async_dma_find_channel(tx_type);
}
EXPORT_SYMBOL_GPL(__async_tx_find_channel);
#else
static int __init async_tx_init(void)
{
printk(KERN_INFO "async_tx: api initialized (sync-only)\n");
return 0;
}

static void __exit async_tx_exit(void)
{
do { } while (0);
}
#endif


Expand Down Expand Up @@ -298,9 +290,6 @@ void async_tx_quiesce(struct dma_async_tx_descriptor **tx)
}
EXPORT_SYMBOL_GPL(async_tx_quiesce);

module_init(async_tx_init);
module_exit(async_tx_exit);

MODULE_AUTHOR("Intel Corporation");
MODULE_DESCRIPTION("Asynchronous Bulk Memory Transactions API");
MODULE_LICENSE("GPL");

0 comments on commit af1f951

Please sign in to comment.