Skip to content

Commit

Permalink
s390/crash: make copy_oldmem_page() return number of bytes copied
Browse files Browse the repository at this point in the history
Callback copy_oldmem_page() returns either error code or zero.
Instead, it should return the error code or number of bytes copied.

Fixes: df9694c ("s390/dump: streamline oldmem copy functions")
Reviewed-by: Alexander Egorenkov <egorenar@linux.ibm.com>
Tested-by: Alexander Egorenkov <egorenar@linux.ibm.com>
Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
  • Loading branch information
Alexander Gordeev committed Jun 23, 2022
1 parent cc02e6e commit af2debd
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions arch/s390/kernel/crash_dump.c
Original file line number Diff line number Diff line change
Expand Up @@ -233,9 +233,10 @@ ssize_t copy_oldmem_page(struct iov_iter *iter, unsigned long pfn, size_t csize,
rc = copy_oldmem_user(iter->iov->iov_base, src, csize);
else
rc = copy_oldmem_kernel(iter->kvec->iov_base, src, csize);
if (!rc)
iov_iter_advance(iter, csize);
return rc;
if (rc < 0)
return rc;
iov_iter_advance(iter, csize);
return csize;
}

/*
Expand Down

0 comments on commit af2debd

Please sign in to comment.