Skip to content

Commit

Permalink
tcp: expose sk_state in tcp_retransmit_skb tracepoint
Browse files Browse the repository at this point in the history
After sk_state exposed, we can get in which state this retransmission
occurs. That could give us more detail for dignostic.
For example, if this retransmission occurs in SYN_SENT state, it may
also indicates that the syn packet may be dropped on the remote peer due
to syn backlog queue full and then we could check the remote peer.

BTW,SYNACK retransmission is traced in tcp_retransmit_synack tracepoint.

Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Yafang Shao authored and David S. Miller committed Sep 27, 2018
1 parent 0a71515 commit af4325e
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions include/trace/events/tcp.h
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ DECLARE_EVENT_CLASS(tcp_event_sk_skb,
TP_STRUCT__entry(
__field(const void *, skbaddr)
__field(const void *, skaddr)
__field(int, state)
__field(__u16, sport)
__field(__u16, dport)
__array(__u8, saddr, 4)
Expand All @@ -70,6 +71,7 @@ DECLARE_EVENT_CLASS(tcp_event_sk_skb,

__entry->skbaddr = skb;
__entry->skaddr = sk;
__entry->state = sk->sk_state;

__entry->sport = ntohs(inet->inet_sport);
__entry->dport = ntohs(inet->inet_dport);
Expand All @@ -84,9 +86,10 @@ DECLARE_EVENT_CLASS(tcp_event_sk_skb,
sk->sk_v6_rcv_saddr, sk->sk_v6_daddr);
),

TP_printk("sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6c daddrv6=%pI6c",
TP_printk("sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6c daddrv6=%pI6c state=%s\n",
__entry->sport, __entry->dport, __entry->saddr, __entry->daddr,
__entry->saddr_v6, __entry->daddr_v6)
__entry->saddr_v6, __entry->daddr_v6,
show_tcp_state_name(__entry->state))
);

DEFINE_EVENT(tcp_event_sk_skb, tcp_retransmit_skb,
Expand Down

0 comments on commit af4325e

Please sign in to comment.