Skip to content

Commit

Permalink
clockevents: Remove the per cpu tick skew
Browse files Browse the repository at this point in the history
Historically, Linux has tried to make the regular timer tick on the
various CPUs not happen at the same time, to avoid contention on
xtime_lock.

Nowadays, with the tickless kernel, this contention no longer happens
since time keeping and updating are done differently. In addition,
this skew is actually hurting power consumption in a measurable way on
many-core systems.

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
LKML-Reference: <20100727210210.58d3118c@infradead.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Arjan van de Ven authored and Thomas Gleixner committed Aug 2, 2010
1 parent 2b08de0 commit af5ab27
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions kernel/time/tick-sched.c
Original file line number Diff line number Diff line change
Expand Up @@ -780,7 +780,6 @@ void tick_setup_sched_timer(void)
{
struct tick_sched *ts = &__get_cpu_var(tick_cpu_sched);
ktime_t now = ktime_get();
u64 offset;

/*
* Emulate tick processing via per-CPU hrtimers:
Expand All @@ -790,10 +789,6 @@ void tick_setup_sched_timer(void)

/* Get the next period (per cpu) */
hrtimer_set_expires(&ts->sched_timer, tick_init_jiffy_update());
offset = ktime_to_ns(tick_period) >> 1;
do_div(offset, num_possible_cpus());
offset *= smp_processor_id();
hrtimer_add_expires_ns(&ts->sched_timer, offset);

for (;;) {
hrtimer_forward(&ts->sched_timer, now, tick_period);
Expand Down

0 comments on commit af5ab27

Please sign in to comment.