Skip to content

Commit

Permalink
net: stmmac: provide function for restarting sw LPI timer
Browse files Browse the repository at this point in the history
Provide a function that encapsulates restarting the software LPI
timer when we have determined that the transmit path is busy, or
whether the EEE parameters have changed.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1tXItW-000MBU-KQ@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Russell King (Oracle) authored and Jakub Kicinski committed Jan 15, 2025
1 parent 82f2025 commit af5dc22
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -416,6 +416,11 @@ static bool stmmac_eee_tx_busy(struct stmmac_priv *priv)
return false;
}

static void stmmac_restart_sw_lpi_timer(struct stmmac_priv *priv)
{
mod_timer(&priv->eee_ctrl_timer, STMMAC_LPI_T(priv->tx_lpi_timer));
}

/**
* stmmac_enable_eee_mode - check and enter in LPI mode
* @priv: driver private structure
Expand All @@ -437,8 +442,7 @@ static int stmmac_enable_eee_mode(struct stmmac_priv *priv)
static void stmmac_try_to_start_sw_lpi(struct stmmac_priv *priv)
{
if (stmmac_enable_eee_mode(priv))
mod_timer(&priv->eee_ctrl_timer,
STMMAC_LPI_T(priv->tx_lpi_timer));
stmmac_restart_sw_lpi_timer(priv);
}

/**
Expand Down Expand Up @@ -526,8 +530,7 @@ static void stmmac_eee_init(struct stmmac_priv *priv, bool active)
/* Use software LPI mode */
priv->eee_sw_timer_en = true;
stmmac_disable_hw_lpi_timer(priv);
mod_timer(&priv->eee_ctrl_timer,
STMMAC_LPI_T(priv->tx_lpi_timer));
stmmac_restart_sw_lpi_timer(priv);
}

priv->eee_enabled = true;
Expand Down

0 comments on commit af5dc22

Please sign in to comment.