Skip to content

Commit

Permalink
pwm: spear: Don't modify HW state in .remove callback
Browse files Browse the repository at this point in the history
[ Upstream commit b601a18 ]

A consumer is expected to disable a PWM before calling pwm_put(). And if
they didn't there is hopefully a good reason (or the consumer needs
fixing). Also if disabling an enabled PWM was the right thing to do,
this should better be done in the framework instead of in each low level
driver.

So drop the hardware modification from the .remove() callback.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Uwe Kleine-König authored and Greg Kroah-Hartman committed Jul 20, 2021
1 parent f16b1d7 commit af619a7
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions drivers/pwm/pwm-spear.c
Original file line number Diff line number Diff line change
Expand Up @@ -231,10 +231,6 @@ static int spear_pwm_probe(struct platform_device *pdev)
static int spear_pwm_remove(struct platform_device *pdev)
{
struct spear_pwm_chip *pc = platform_get_drvdata(pdev);
int i;

for (i = 0; i < NUM_PWM; i++)
pwm_disable(&pc->chip.pwms[i]);

/* clk was prepared in probe, hence unprepare it here */
clk_unprepare(pc->clk);
Expand Down

0 comments on commit af619a7

Please sign in to comment.