Skip to content

Commit

Permalink
selftests: xsk: Make xdp_flags and bind_flags local
Browse files Browse the repository at this point in the history 
Make xdp_flags and bind_flags local instead of global by moving them
into the interface object. These flags decide if the socket should be
created in SKB mode or in DRV mode and therefore they are sticky and
will survive a test_spec_reset. Since every test is first run in SKB
mode then in DRV mode, this change only happens once. With this
change, the configured_mode global variable can also be
erradicated. The first test_spec_init() also becomes superfluous and
can be eliminated.

Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Link: https://lore.kernel.org/bpf/20210907071928.9750-13-magnus.karlsson@gmail.com
  • Loading branch information
Magnus Karlsson authored and Daniel Borkmann committed Sep 10, 2021
1 parent 85c6c95 commit af6731d
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 32 deletions.
57 changes: 29 additions & 28 deletions tools/testing/selftests/bpf/xdpxceiver.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,10 @@ static void __exit_with_error(int error, const char *file, const char *func, int

#define exit_with_error(error) __exit_with_error(error, __FILE__, __func__, __LINE__)

#define print_ksft_result(test)\
(ksft_test_result_pass("PASS: %s %s\n", configured_mode ? "DRV" : "SKB", \
(test)->name))
#define mode_string(test) (test)->ifobj_tx->xdp_flags & XDP_FLAGS_SKB_MODE ? "SKB" : "DRV"

#define print_ksft_result(test) \
(ksft_test_result_pass("PASS: %s %s\n", mode_string(test), (test)->name))

static void memset32_htonl(void *dest, u32 val, u32 size)
{
Expand Down Expand Up @@ -275,8 +276,8 @@ static int xsk_configure_socket(struct xsk_socket_info *xsk, struct xsk_umem_inf
cfg.rx_size = xsk->rxqsize;
cfg.tx_size = XSK_RING_PROD__DEFAULT_NUM_DESCS;
cfg.libbpf_flags = 0;
cfg.xdp_flags = xdp_flags;
cfg.bind_flags = xdp_bind_flags;
cfg.xdp_flags = ifobject->xdp_flags;
cfg.bind_flags = ifobject->bind_flags;

txr = ifobject->tx_on ? &xsk->tx : NULL;
rxr = ifobject->rx_on ? &xsk->rx : NULL;
Expand Down Expand Up @@ -333,7 +334,8 @@ static bool validate_interface(struct ifobject *ifobj)
return true;
}

static void parse_command_line(struct test_spec *test, int argc, char **argv)
static void parse_command_line(struct ifobject *ifobj_tx, struct ifobject *ifobj_rx, int argc,
char **argv)
{
struct ifobject *ifobj;
u32 interface_nb = 0;
Expand All @@ -351,9 +353,9 @@ static void parse_command_line(struct test_spec *test, int argc, char **argv)
switch (c) {
case 'i':
if (interface_nb == 0)
ifobj = test->ifobj_tx;
ifobj = ifobj_tx;
else if (interface_nb == 1)
ifobj = test->ifobj_rx;
ifobj = ifobj_rx;
else
break;

Expand Down Expand Up @@ -414,9 +416,24 @@ static void __test_spec_init(struct test_spec *test, struct ifobject *ifobj_tx,
}

static void test_spec_init(struct test_spec *test, struct ifobject *ifobj_tx,
struct ifobject *ifobj_rx)
struct ifobject *ifobj_rx, enum test_mode mode)
{
u32 i;

memset(test, 0, sizeof(*test));

for (i = 0; i < MAX_INTERFACES; i++) {
struct ifobject *ifobj = i ? ifobj_rx : ifobj_tx;

ifobj->xdp_flags = XDP_FLAGS_UPDATE_IF_NOEXIST;
if (mode == TEST_MODE_SKB)
ifobj->xdp_flags |= XDP_FLAGS_SKB_MODE;
else
ifobj->xdp_flags |= XDP_FLAGS_DRV_MODE;

ifobj->bind_flags = XDP_USE_NEED_WAKEUP | XDP_COPY;
}

__test_spec_init(test, ifobj_tx, ifobj_rx);
}

Expand Down Expand Up @@ -1011,27 +1028,13 @@ static void init_iface(struct ifobject *ifobj, const char *dst_mac, const char *
ifobj->func_ptr = func_ptr;
}

static void run_pkt_test(struct test_spec *test, int mode, int type)
static void run_pkt_test(struct test_spec *test, enum test_mode mode, enum test_type type)
{
test_type = type;

/* reset defaults after potential previous test */
xdp_flags = XDP_FLAGS_UPDATE_IF_NOEXIST;
stat_test_type = -1;

configured_mode = mode;

switch (mode) {
case (TEST_MODE_SKB):
xdp_flags |= XDP_FLAGS_SKB_MODE;
break;
case (TEST_MODE_DRV):
xdp_flags |= XDP_FLAGS_DRV_MODE;
break;
default:
break;
}

switch (test_type) {
case TEST_TYPE_STATS:
testapp_stats(test);
Expand Down Expand Up @@ -1111,11 +1114,9 @@ int main(int argc, char **argv)
if (!ifobj_rx)
exit_with_error(ENOMEM);

test_spec_init(&test, ifobj_tx, ifobj_rx);

setlocale(LC_ALL, "");

parse_command_line(&test, argc, argv);
parse_command_line(ifobj_tx, ifobj_rx, argc, argv);

if (!validate_interface(ifobj_tx) || !validate_interface(ifobj_rx)) {
usage(basename(argv[0]));
Expand All @@ -1131,7 +1132,7 @@ int main(int argc, char **argv)

for (i = 0; i < TEST_MODE_MAX; i++)
for (j = 0; j < TEST_TYPE_MAX; j++) {
test_spec_init(&test, ifobj_tx, ifobj_rx);
test_spec_init(&test, ifobj_tx, ifobj_rx, i);
run_pkt_test(&test, i, j);
usleep(USLEEP_MAX);
}
Expand Down
6 changes: 2 additions & 4 deletions tools/testing/selftests/bpf/xdpxceiver.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -68,14 +68,10 @@ enum stat_test_type {
STAT_TEST_TYPE_MAX
};

static int configured_mode;
static bool opt_pkt_dump;
static int test_type;

static bool opt_verbose;

static u32 xdp_flags = XDP_FLAGS_UPDATE_IF_NOEXIST;
static u32 xdp_bind_flags = XDP_USE_NEED_WAKEUP | XDP_COPY;
static int stat_test_type;

struct xsk_umem_info {
Expand Down Expand Up @@ -122,6 +118,8 @@ struct ifobject {
int ns_fd;
u32 dst_ip;
u32 src_ip;
u32 xdp_flags;
u32 bind_flags;
u16 src_port;
u16 dst_port;
bool tx_on;
Expand Down

0 comments on commit af6731d

Please sign in to comment.