Skip to content

Commit

Permalink
ip6_gre: fix potential memory leak in ip6erspan_rcv
Browse files Browse the repository at this point in the history
If md is NULL, tun_dst must be freed, otherwise it will cause memory
leak.

Fixes: ef7baf5 ("ip6_gre: add ip6 erspan collect_md mode")
Cc: William Tu <u9012063@gmail.com>
Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Haishuang Yan authored and David S. Miller committed Dec 20, 2017
1 parent 50670b6 commit afb4c97
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion net/ipv6/ip6_gre.c
Original file line number Diff line number Diff line change
Expand Up @@ -550,8 +550,10 @@ static int ip6erspan_rcv(struct sk_buff *skb, int gre_hdr_len,

info = &tun_dst->u.tun_info;
md = ip_tunnel_info_opts(info);
if (!md)
if (!md) {
dst_release((struct dst_entry *)tun_dst);
return PACKET_REJECT;
}

memcpy(md, pkt_md, sizeof(*md));
md->version = ver;
Expand Down

0 comments on commit afb4c97

Please sign in to comment.