Skip to content

Commit

Permalink
ACPI: scan: Make acpi_walk_dep_device_list()
Browse files Browse the repository at this point in the history
Because acpi_walk_dep_device_list() is only called by the code in the
file in which it is defined, make it static, drop the export of it
and drop its header from acpi.h.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
  • Loading branch information
Rafael J. Wysocki committed Jun 17, 2021
1 parent ad4d451 commit aff0dbd
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
7 changes: 3 additions & 4 deletions drivers/acpi/scan.c
Original file line number Diff line number Diff line change
Expand Up @@ -2139,9 +2139,9 @@ static int acpi_scan_clear_dep(struct acpi_dep_data *dep, void *data)
* negative value is returned by the callback then the loop is broken and that
* value is returned as the final error.
*/
int acpi_walk_dep_device_list(acpi_handle handle,
int (*callback)(struct acpi_dep_data *, void *),
void *data)
static int acpi_walk_dep_device_list(acpi_handle handle,
int (*callback)(struct acpi_dep_data *, void *),
void *data)
{
struct acpi_dep_data *dep, *tmp;
int ret = 0;
Expand All @@ -2158,7 +2158,6 @@ int acpi_walk_dep_device_list(acpi_handle handle,

return ret > 0 ? 0 : ret;
}
EXPORT_SYMBOL_GPL(acpi_walk_dep_device_list);

/**
* acpi_dev_clear_dependencies - Inform consumers that the device is now active
Expand Down
3 changes: 0 additions & 3 deletions include/linux/acpi.h
Original file line number Diff line number Diff line change
Expand Up @@ -666,9 +666,6 @@ extern bool acpi_driver_match_device(struct device *dev,
const struct device_driver *drv);
int acpi_device_uevent_modalias(struct device *, struct kobj_uevent_env *);
int acpi_device_modalias(struct device *, char *, int);
int acpi_walk_dep_device_list(acpi_handle handle,
int (*callback)(struct acpi_dep_data *, void *),
void *data);

struct platform_device *acpi_create_platform_device(struct acpi_device *,
struct property_entry *);
Expand Down

0 comments on commit aff0dbd

Please sign in to comment.