Skip to content

Commit

Permalink
x86: fix compile error due to X86_TRAP_NMI use in asm files
Browse files Browse the repository at this point in the history
It's an enum, not a #define, you can't use it in asm files.

Introduced in commit 5fa1019 ("x86: Ignore NMIs that come in during
early boot"), and sadly I didn't compile-test things like I should have
before pushing out.

My weak excuse is that the x86 tree generally doesn't introduce stupid
things like this (and the ARM pull afterwards doesn't cause me to do a
compile-test either, since I don't cross-compile).

Cc: Don Zickus <dzickus@redhat.com>
Cc: H. Peter Anvin <hpa@linux.intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Linus Torvalds committed Mar 8, 2014
1 parent 4d7eaa1 commit b01d4e6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion arch/x86/kernel/head_32.S
Original file line number Diff line number Diff line change
Expand Up @@ -545,7 +545,7 @@ ENDPROC(early_idt_handlers)
ENTRY(early_idt_handler)
cld

cmpl $X86_TRAP_NMI,(%esp)
cmpl $2,(%esp) # X86_TRAP_NMI
je is_nmi # Ignore NMI

cmpl $2,%ss:early_recursion_flag
Expand Down
2 changes: 1 addition & 1 deletion arch/x86/kernel/head_64.S
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ early_idt_handlers:
ENTRY(early_idt_handler)
cld

cmpl $X86_TRAP_NMI,(%rsp)
cmpl $2,(%rsp) # X86_TRAP_NMI
je is_nmi # Ignore NMI

cmpl $2,early_recursion_flag(%rip)
Expand Down

0 comments on commit b01d4e6

Please sign in to comment.