Skip to content

Commit

Permalink
Merge git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty-2.6
Browse files Browse the repository at this point in the history
* git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty-2.6:
  serial: 8250: add serial transmitter fully empty test
  • Loading branch information
Linus Torvalds committed Feb 17, 2010
2 parents 1868821 + bca4761 commit b0483e7
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions drivers/serial/8250.c
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,9 @@ static unsigned int skip_txen_test; /* force skip of txen test at init time */

#define PASS_LIMIT 256

#define BOTH_EMPTY (UART_LSR_TEMT | UART_LSR_THRE)


/*
* We default to IRQ0 for the "no irq" hack. Some
* machine types want others as well - they're free
Expand Down Expand Up @@ -1792,7 +1795,7 @@ static unsigned int serial8250_tx_empty(struct uart_port *port)
up->lsr_saved_flags |= lsr & LSR_SAVE_FLAGS;
spin_unlock_irqrestore(&up->port.lock, flags);

return lsr & UART_LSR_TEMT ? TIOCSER_TEMT : 0;
return (lsr & BOTH_EMPTY) == BOTH_EMPTY ? TIOCSER_TEMT : 0;
}

static unsigned int serial8250_get_mctrl(struct uart_port *port)
Expand Down Expand Up @@ -1850,8 +1853,6 @@ static void serial8250_break_ctl(struct uart_port *port, int break_state)
spin_unlock_irqrestore(&up->port.lock, flags);
}

#define BOTH_EMPTY (UART_LSR_TEMT | UART_LSR_THRE)

/*
* Wait for transmitter & holding register to empty
*/
Expand Down

0 comments on commit b0483e7

Please sign in to comment.