Skip to content

Commit

Permalink
HID: hid-steam: Don't use cancel_delayed_work_sync in IRQ context
Browse files Browse the repository at this point in the history
Lockdep reported that, as steam_do_deck_input_event is called from
steam_raw_event inside of an IRQ context, it can lead to issues if that IRQ
occurs while the work to be cancelled is running. By using cancel_delayed_work,
this issue can be avoided. The exact ordering of the work and the event
processing is not super important, so this is safe.

Fixes: cd438e5 ("HID: hid-steam: Add gamepad-only mode switched to by holding options")
Signed-off-by: Vicki Pfau <vi@endrift.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
  • Loading branch information
Vicki Pfau authored and Jiri Kosina committed Feb 7, 2025
1 parent 7950424 commit b051ffa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/hid/hid-steam.c
Original file line number Diff line number Diff line change
Expand Up @@ -1617,7 +1617,7 @@ static void steam_do_deck_input_event(struct steam_device *steam,

if (!(b9 & BIT(6)) && steam->did_mode_switch) {
steam->did_mode_switch = false;
cancel_delayed_work_sync(&steam->mode_switch);
cancel_delayed_work(&steam->mode_switch);
} else if (!steam->client_opened && (b9 & BIT(6)) && !steam->did_mode_switch) {
steam->did_mode_switch = true;
schedule_delayed_work(&steam->mode_switch, 45 * HZ / 100);
Expand Down

0 comments on commit b051ffa

Please sign in to comment.