Skip to content

Commit

Permalink
net: sealevel: fix the comments style issue
Browse files Browse the repository at this point in the history
Networking block comments don't use an empty /* line,
use /* Comment...

Block comments use * on subsequent lines.
Block comments use a trailing */ on a separate line.

This patch fixes the comments style issues.

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Peng Li authored and Jakub Kicinski committed Jun 1, 2021
1 parent 04d7ad8 commit b086ebf
Showing 1 changed file with 18 additions and 42 deletions.
60 changes: 18 additions & 42 deletions drivers/net/wan/sealevel.c
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
// SPDX-License-Identifier: GPL-2.0-or-later
/*
* Sealevel Systems 4021 driver.
/* Sealevel Systems 4021 driver.
*
* (c) Copyright 1999, 2001 Alan Cox
* (c) Copyright 2001 Red Hat Inc.
Expand Down Expand Up @@ -40,17 +39,14 @@ struct slvl_board {
int iobase;
};

/*
* Network driver support routines
*/
/* Network driver support routines */

static inline struct slvl_device *dev_to_chan(struct net_device *dev)
{
return (struct slvl_device *)dev_to_hdlc(dev)->priv;
}

/*
* Frame receive. Simple for our card as we do HDLC and there
/* Frame receive. Simple for our card as we do HDLC and there
* is no funny garbage involved
*/

Expand All @@ -64,19 +60,15 @@ static void sealevel_input(struct z8530_channel *c, struct sk_buff *skb)
netif_rx(skb);
}

/*
* We've been placed in the UP state
*/
/* We've been placed in the UP state */

static int sealevel_open(struct net_device *d)
{
struct slvl_device *slvl = dev_to_chan(d);
int err = -1;
int unit = slvl->channel;

/*
* Link layer up.
*/
/* Link layer up. */

switch (unit) {
case 0:
Expand Down Expand Up @@ -114,9 +106,7 @@ static int sealevel_close(struct net_device *d)
struct slvl_device *slvl = dev_to_chan(d);
int unit = slvl->channel;

/*
* Discard new frames
*/
/* Discard new frames */

slvl->chan->rx_function = z8530_null_rx;

Expand All @@ -137,13 +127,12 @@ static int sealevel_close(struct net_device *d)
static int sealevel_ioctl(struct net_device *d, struct ifreq *ifr, int cmd)
{
/* struct slvl_device *slvl=dev_to_chan(d);
z8530_ioctl(d,&slvl->sync.chanA,ifr,cmd) */
* z8530_ioctl(d,&slvl->sync.chanA,ifr,cmd)
*/
return hdlc_ioctl(d, ifr, cmd);
}

/*
* Passed network frames, fire them downwind.
*/
/* Passed network frames, fire them downwind. */

static netdev_tx_t sealevel_queue_xmit(struct sk_buff *skb,
struct net_device *d)
Expand Down Expand Up @@ -189,19 +178,15 @@ static int slvl_setup(struct slvl_device *sv, int iobase, int irq)
return 0;
}

/*
* Allocate and setup Sealevel board.
*/
/* Allocate and setup Sealevel board. */

static __init struct slvl_board *slvl_init(int iobase, int irq,
int txdma, int rxdma, int slow)
{
struct z8530_dev *dev;
struct slvl_board *b;

/*
* Get the needed I/O space
*/
/* Get the needed I/O space */

if (!request_region(iobase, 8, "Sealevel 4021")) {
pr_warn("I/O 0x%X already in use\n", iobase);
Expand All @@ -220,17 +205,13 @@ static __init struct slvl_board *slvl_init(int iobase, int irq,

dev = &b->board;

/*
* Stuff in the I/O addressing
*/
/* Stuff in the I/O addressing */

dev->active = 0;

b->iobase = iobase;

/*
* Select 8530 delays for the old board
*/
/* Select 8530 delays for the old board */

if (slow)
iobase |= Z8530_PORT_SLEEP;
Expand All @@ -243,14 +224,13 @@ static __init struct slvl_board *slvl_init(int iobase, int irq,
dev->chanA.irqs = &z8530_nop;
dev->chanB.irqs = &z8530_nop;

/*
* Assert DTR enable DMA
*/
/* Assert DTR enable DMA */

outb(3 | (1 << 7), b->iobase + 4);

/* We want a fast IRQ for this device. Actually we'd like an even faster
IRQ ;) - This is one driver RtLinux is made for */
* IRQ ;) - This is one driver RtLinux is made for
*/

if (request_irq(irq, z8530_interrupt, 0,
"SeaLevel", dev) < 0) {
Expand All @@ -274,9 +254,7 @@ static __init struct slvl_board *slvl_init(int iobase, int irq,

disable_irq(irq);

/*
* Begin normal initialise
*/
/* Begin normal initialise */

if (z8530_init(dev) != 0) {
pr_err("Z8530 series device not found\n");
Expand All @@ -291,9 +269,7 @@ static __init struct slvl_board *slvl_init(int iobase, int irq,
z8530_channel_load(&dev->chanB, z8530_hdlc_kilostream_85230);
}

/*
* Now we can take the IRQ
*/
/* Now we can take the IRQ */

enable_irq(irq);

Expand Down

0 comments on commit b086ebf

Please sign in to comment.