Skip to content

Commit

Permalink
openrisc: header file cleanups
Browse files Browse the repository at this point in the history
elf.h: We can export some of these symbols to userspace.  libc needs them
and we just as well provide them as asm/elf.h as copying them into separate
libc headers.

ptrace.h: Having padding in the user_regs_struct isn't of any particular
value and just confuses GDB.  spr_defs isn't needed in userspace; libc
has its own copy anyway.

Signed-off-by: Jonas Bonn <jonas@southpole.se>
  • Loading branch information
Jonas Bonn committed May 8, 2012
1 parent 4971f2b commit b0e026f
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 7 deletions.
3 changes: 2 additions & 1 deletion arch/openrisc/include/asm/Kbuild
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
include include/asm-generic/Kbuild.asm

header-y += spr_defs.h
header-y += elf.h
header-y += ucontext.h

generic-y += atomic.h
generic-y += auxvec.h
Expand Down
12 changes: 10 additions & 2 deletions arch/openrisc/include/asm/elf.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,18 @@
#ifndef __ASM_OPENRISC_ELF_H
#define __ASM_OPENRISC_ELF_H

/*
* This files is partially exported to userspace. This allows us to keep
* the ELF bits in one place which should assist in keeping the kernel and
* userspace in sync.
*/

/*
* ELF register definitions..
*/
#include <linux/types.h>
#include <linux/ptrace.h>

/* for struct user_regs_struct definition */
#include <asm/ptrace.h>

/* The OR1K relocation types... not all relevant for module loader */
#define R_OR32_NONE 0
Expand Down Expand Up @@ -62,6 +68,8 @@ typedef unsigned long elf_fpregset_t;

#ifdef __KERNEL__

#include <linux/types.h>

/*
* This is used to ensure we don't load something for the wrong architecture.
*/
Expand Down
6 changes: 2 additions & 4 deletions arch/openrisc/include/asm/ptrace.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@
#ifndef __ASM_OPENRISC_PTRACE_H
#define __ASM_OPENRISC_PTRACE_H

#include <asm/spr_defs.h>

#ifndef __ASSEMBLY__
/*
* This is the layout of the regset returned by the GETREGSET ptrace call
Expand All @@ -30,13 +28,13 @@ struct user_regs_struct {
unsigned long gpr[32];
unsigned long pc;
unsigned long sr;
unsigned long pad1;
unsigned long pad2;
};
#endif

#ifdef __KERNEL__

#include <asm/spr_defs.h>

/*
* Make kernel PTrace/register structures opaque to userspace... userspace can
* access thread state via the regset mechanism. This allows us a bit of
Expand Down

0 comments on commit b0e026f

Please sign in to comment.