Skip to content

Commit

Permalink
net: sfp: add some quirks for GPON modules
Browse files Browse the repository at this point in the history
Marc Micalizzi reports that Huawei MA5671A and Alcatel/Lucent G-010S-P
modules are capable of 2500base-X, but incorrectly report their
capabilities in the EEPROM.  It seems rather common that GPON modules
mis-report.

Let's fix these modules by adding some quirks.

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Russell King authored and David S. Miller committed Nov 21, 2019
1 parent b34bb2c commit b0eae33
Showing 1 changed file with 25 additions and 0 deletions.
25 changes: 25 additions & 0 deletions drivers/net/phy/sfp-bus.c
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,32 @@ struct sfp_bus {
bool started;
};

static void sfp_quirk_2500basex(const struct sfp_eeprom_id *id,
unsigned long *modes)
{
phylink_set(modes, 2500baseX_Full);
}

static const struct sfp_quirk sfp_quirks[] = {
{
// Alcatel Lucent G-010S-P can operate at 2500base-X, but
// incorrectly report 2500MBd NRZ in their EEPROM
.vendor = "ALCATELLUCENT",
.part = "G010SP",
.modes = sfp_quirk_2500basex,
}, {
// Alcatel Lucent G-010S-A can operate at 2500base-X, but
// report 3.2GBd NRZ in their EEPROM
.vendor = "ALCATELLUCENT",
.part = "3FE46541AA",
.modes = sfp_quirk_2500basex,
}, {
// Huawei MA5671A can operate at 2500base-X, but report 1.2GBd
// NRZ in their EEPROM
.vendor = "HUAWEI",
.part = "MA5671A",
.modes = sfp_quirk_2500basex,
},
};

static size_t sfp_strlen(const char *str, size_t maxlen)
Expand Down

0 comments on commit b0eae33

Please sign in to comment.