Skip to content

Commit

Permalink
tools: iio: iio_generic_buffer: make num_loops signed
Browse files Browse the repository at this point in the history
Currently, num_loops is unsigned, but it's set by strtoll, which returns a
(signed) long long int. This could lead to overflow, and it also makes the
check "num_loops < 0" always be false, since num_loops is unsigned.
Setting num_loops to -1 to loop forever is almost working because num_loops
is getting set to a very high number, but it's technically still incorrect.

Fix this issue by making num_loops signed. This also fixes an error found
by Smatch.

Signed-off-by: Martin Kelly <mkelly@xevo.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 55dda0a ("tools: iio: iio_generic_buffer: allow continuous looping")
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
  • Loading branch information
Martin Kelly authored and Jonathan Cameron committed Jan 12, 2019
1 parent 9bcf15f commit b119d3b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/iio/iio_generic_buffer.c
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ static const struct option longopts[] = {

int main(int argc, char **argv)
{
unsigned long long num_loops = 2;
long long num_loops = 2;
unsigned long timedelay = 1000000;
unsigned long buf_len = 128;

Expand Down

0 comments on commit b119d3b

Please sign in to comment.