Skip to content

Commit

Permalink
appletalk: Set error code if register_snap_client failed
Browse files Browse the repository at this point in the history
commit c93ad13 upstream.

If register_snap_client fails in atalk_init,
error code should be set, otherwise it will
triggers NULL pointer dereference while unloading
module.

Fixes: 9804501 ("appletalk: Fix potential NULL pointer dereference in unregister_snap_client")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
YueHaibing authored and Greg Kroah-Hartman committed Dec 13, 2019
1 parent 0977763 commit b136eeb
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions net/appletalk/ddp.c
Original file line number Diff line number Diff line change
Expand Up @@ -1925,6 +1925,7 @@ static int __init atalk_init(void)
ddp_dl = register_snap_client(ddp_snap_id, atalk_rcv);
if (!ddp_dl) {
pr_crit("Unable to register DDP with SNAP.\n");
rc = -ENOMEM;
goto out_sock;
}

Expand Down

0 comments on commit b136eeb

Please sign in to comment.