Skip to content

Commit

Permalink
net: phylink: fix regression when binding a PHY
Browse files Browse the repository at this point in the history
Some PHYs don't support clause 45 access, and return -EOPNOTSUPP from
phy_modify_mmd(), which causes phylink_bringup_phy() to fail. Prevent
this failure by allowing -EOPNOTSUPP to also mean success.

Reported-by: Jiawen Wu <jiawenwu@trustnetic.com>
Tested-by: Jiawen Wu <jiawenwu@trustnetic.com>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/E1tZp1a-001V62-DT@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Russell King (Oracle) authored and Jakub Kicinski committed Jan 21, 2025
1 parent d73a460 commit b1754a6
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion drivers/net/phy/phylink.c
Original file line number Diff line number Diff line change
Expand Up @@ -2268,7 +2268,11 @@ static int phylink_bringup_phy(struct phylink *pl, struct phy_device *phy,
/* Explicitly configure whether the PHY is allowed to stop it's
* receive clock.
*/
return phy_eee_rx_clock_stop(phy, pl->config->eee_rx_clk_stop_enable);
ret = phy_eee_rx_clock_stop(phy, pl->config->eee_rx_clk_stop_enable);
if (ret == -EOPNOTSUPP)
ret = 0;

return ret;
}

static int phylink_attach_phy(struct phylink *pl, struct phy_device *phy,
Expand Down

0 comments on commit b1754a6

Please sign in to comment.