Skip to content

Commit

Permalink
drm/i915/selftests: Skip RPS tests on Ironlake (only IPS)
Browse files Browse the repository at this point in the history
Since Ironlake uses intel_ips.ko for its dynamic frequency adjustment,
we do not have direct control over the frequency management so such
tests are defunct. Similarly, we can't check the gen6+ RPS registers on
Ironlake.

Hopefully this catches all the invalid tests now that Ironlake has
rejoined the dynamic GPU frequency club. There is an opportunity for the
reader to add tests to exercise MEMINTRSTS and co.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20201022210814.23004-1-chris@chris-wilson.co.uk
  • Loading branch information
Chris Wilson committed Oct 23, 2020
1 parent 537f9c8 commit b1cff58
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/gpu/drm/i915/gt/selftest_rps.c
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ int live_rps_clock_interval(void *arg)
struct igt_spinner spin;
int err = 0;

if (!intel_rps_is_enabled(rps))
if (!intel_rps_is_enabled(rps) || INTEL_GEN(gt->i915) < 6)
return 0;

if (igt_spinner_init(&spin, gt))
Expand Down Expand Up @@ -1028,7 +1028,7 @@ int live_rps_interrupt(void *arg)
* First, let's check whether or not we are receiving interrupts.
*/

if (!intel_rps_has_interrupts(rps))
if (!intel_rps_has_interrupts(rps) || INTEL_GEN(gt->i915) < 6)
return 0;

intel_gt_pm_get(gt);
Expand Down Expand Up @@ -1133,7 +1133,7 @@ int live_rps_power(void *arg)
* that theory.
*/

if (!intel_rps_is_enabled(rps))
if (!intel_rps_is_enabled(rps) || INTEL_GEN(gt->i915) < 6)
return 0;

if (!librapl_energy_uJ())
Expand Down Expand Up @@ -1237,7 +1237,7 @@ int live_rps_dynamic(void *arg)
* moving parts into dynamic reclocking based on load.
*/

if (!intel_rps_is_enabled(rps))
if (!intel_rps_is_enabled(rps) || INTEL_GEN(gt->i915) < 6)
return 0;

if (igt_spinner_init(&spin, gt))
Expand Down

0 comments on commit b1cff58

Please sign in to comment.