Skip to content

Commit

Permalink
intel_scu_ipcutil: underflow in scu_reg_access()
Browse files Browse the repository at this point in the history
"count" is controlled by the user and it can be negative.  Let's prevent
that by making it unsigned.  You have to have CAP_SYS_RAWIO to call this
function so the bug is not as serious as it could be.

Fixes: 5369c02 ('intel_scu_ipc: Utility driver for intel scu ipc')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: stable@vger.kernel.org
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
  • Loading branch information
Dan Carpenter authored and Darren Hart committed Jan 30, 2016
1 parent 1c319e7 commit b1d353a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/platform/x86/intel_scu_ipcutil.c
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ struct scu_ipc_data {

static int scu_reg_access(u32 cmd, struct scu_ipc_data *data)
{
int count = data->count;
unsigned int count = data->count;

if (count == 0 || count == 3 || count > 4)
return -EINVAL;
Expand Down

0 comments on commit b1d353a

Please sign in to comment.