Skip to content

Commit

Permalink
batman-adv: Use netif_rx_any_context().
Browse files Browse the repository at this point in the history
The usage of in_interrupt() in non-core code is phased out. Ideally the
information of the calling context should be passed by the callers or the
functions be split as appropriate.

The attempt to consolidate the code by passing an arguemnt or by
distangling it failed due lack of knowledge about this driver and because
the call chains are hard to follow.

As a stop gap use netif_rx_any_context() which invokes the correct code path
depending on context and confines the in_interrupt() usage to core code.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
  • Loading branch information
Sebastian Andrzej Siewior authored and Simon Wunderlich committed Feb 13, 2021
1 parent 25d81f9 commit b1de0f0
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions net/batman-adv/bridge_loop_avoidance.c
Original file line number Diff line number Diff line change
Expand Up @@ -438,10 +438,7 @@ static void batadv_bla_send_claim(struct batadv_priv *bat_priv, u8 *mac,
batadv_add_counter(bat_priv, BATADV_CNT_RX_BYTES,
skb->len + ETH_HLEN);

if (in_interrupt())
netif_rx(skb);
else
netif_rx_ni(skb);
netif_rx_any_context(skb);
out:
if (primary_if)
batadv_hardif_put(primary_if);
Expand Down

0 comments on commit b1de0f0

Please sign in to comment.