Skip to content

Commit

Permalink
[PATCH] PCI: cleanup unused variable about msi driver
Browse files Browse the repository at this point in the history
In IA64 platform, msi driver does not use irq_vector variable, and in
x86 platform LAST_DEVICE_VECTOR should one before FIRST_SYSTEM_VECTOR,
this patch modify this.

Signed-off-by: bibo, mao <bibo.mao@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
bibo,mao authored and Greg Kroah-Hartman committed Jun 21, 2006
1 parent 99dc804 commit b209a6e
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 7 deletions.
5 changes: 0 additions & 5 deletions drivers/pci/msi.c
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ static int nr_msix_devices;

#ifndef CONFIG_X86_IO_APIC
int vector_irq[NR_VECTORS] = { [0 ... NR_VECTORS - 1] = -1};
u8 irq_vector[NR_IRQ_VECTORS];
#endif

static struct msi_ops *msi_ops;
Expand Down Expand Up @@ -383,10 +382,6 @@ static int msi_init(void)
return status;
}

#ifndef CONFIG_X86_IO_APIC
irq_vector[0] = FIRST_DEVICE_VECTOR;
#endif

if (last_alloc_vector < 0) {
pci_msi_enable = 0;
printk(KERN_WARNING "PCI: No interrupt vectors available for MSI\n");
Expand Down
2 changes: 1 addition & 1 deletion include/asm-i386/msi.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#include <asm/desc.h>
#include <mach_apic.h>

#define LAST_DEVICE_VECTOR 232
#define LAST_DEVICE_VECTOR (FIRST_SYSTEM_VECTOR - 1)
#define MSI_TARGET_CPU_SHIFT 12

extern struct msi_ops msi_apic_ops;
Expand Down
2 changes: 1 addition & 1 deletion include/asm-x86_64/msi.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#include <asm/mach_apic.h>
#include <asm/smp.h>

#define LAST_DEVICE_VECTOR 232
#define LAST_DEVICE_VECTOR (FIRST_SYSTEM_VECTOR - 1)
#define MSI_TARGET_CPU_SHIFT 12

extern struct msi_ops msi_apic_ops;
Expand Down

0 comments on commit b209a6e

Please sign in to comment.