Skip to content

Commit

Permalink
ALSA: ppc/awacs: shut up maybe-uninitialized warning
Browse files Browse the repository at this point in the history
The awacs sound driver produces a false-positive warning in ppc64_defconfig:

sound/ppc/awacs.c: In function 'snd_pmac_awacs_init':
include/sound/control.h:219:9: warning: 'master_vol' may be used uninitialized in this function [-Wmaybe-uninitialized]

I haven't come up with a good way to rewrite the code to avoid the
warning, so here is a bad one: I initialize the variable before
the conditionall initialization so gcc no longer has to worry about
it.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
Arnd Bergmann authored and Takashi Iwai committed Jul 5, 2016
1 parent cf7d7ed commit b268c34
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions sound/ppc/awacs.c
Original file line number Diff line number Diff line change
Expand Up @@ -991,6 +991,7 @@ snd_pmac_awacs_init(struct snd_pmac *chip)
if (err < 0)
return err;
}
master_vol = NULL;
if (pm7500)
err = build_mixers(chip,
ARRAY_SIZE(snd_pmac_awacs_mixers_pmac7500),
Expand Down

0 comments on commit b268c34

Please sign in to comment.