Skip to content

Commit

Permalink
ASoC: SOF: topology: Use kmemdup() to replace kzalloc + memcpy
Browse files Browse the repository at this point in the history
fix memdup.cocci warning:
sound/soc/sof/topology.c:876:19-26: WARNING opportunity for kmemdup

Generated by: scripts/coccinelle/api/memdup.cocci

Signed-off-by: Yihao Han <hanyihao@vivo.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20220317093841.3414-1-hanyihao@vivo.com
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Yihao Han authored and Mark Brown committed Mar 17, 2022
1 parent 753132f commit b26f965
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions sound/soc/sof/topology.c
Original file line number Diff line number Diff line change
Expand Up @@ -873,11 +873,10 @@ static int sof_control_load_bytes(struct snd_soc_component *scomp,

/* copy the private data */
if (priv_size > 0) {
scontrol->priv = kzalloc(priv_size, GFP_KERNEL);
scontrol->priv = kmemdup(control->priv.data, priv_size, GFP_KERNEL);
if (!scontrol->priv)
return -ENOMEM;

memcpy(scontrol->priv, control->priv.data, priv_size);
scontrol->priv_size = priv_size;
}

Expand Down

0 comments on commit b26f965

Please sign in to comment.