Skip to content

Commit

Permalink
hfsplus: %L-to-%ll, macro correction, and remove unneeded braces
Browse files Browse the repository at this point in the history
Clean-up based on checkpatch.pl report against unnecessary braces
(`{' and `}'), non-standard format option %Lu (%llu recommended)
as well as one trailing statement in a macro definition which
should have been on the next line.

Signed-off-by: Anton Salikhmetov <alexo@tuxera.com>
Signed-off-by: Christoph Hellwig <hch@tuxera.com>
  • Loading branch information
Anton Salikhmetov authored and Christoph Hellwig committed Dec 16, 2010
1 parent 20b7643 commit b2837fc
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 14 deletions.
9 changes: 3 additions & 6 deletions fs/hfsplus/bnode.c
Original file line number Diff line number Diff line change
Expand Up @@ -363,9 +363,8 @@ void hfs_bnode_unlink(struct hfs_bnode *node)
tree->leaf_tail = node->prev;

/* move down? */
if (!node->prev && !node->next) {
if (!node->prev && !node->next)
dprint(DBG_BNODE_MOD, "hfs_btree_del_level\n");
}
if (!node->parent) {
tree->root = 0;
tree->depth = 0;
Expand All @@ -392,11 +391,9 @@ struct hfs_bnode *hfs_bnode_findhash(struct hfs_btree *tree, u32 cnid)
}

for (node = tree->node_hash[hfs_bnode_hash(cnid)];
node; node = node->next_hash) {
if (node->this == cnid) {
node; node = node->next_hash)
if (node->this == cnid)
return node;
}
}
return NULL;
}

Expand Down
16 changes: 9 additions & 7 deletions fs/hfsplus/extents.c
Original file line number Diff line number Diff line change
Expand Up @@ -397,12 +397,13 @@ int hfsplus_file_extend(struct inode *inode)
u32 start, len, goal;
int res;

if (sbi->alloc_file->i_size * 8 <
sbi->total_blocks - sbi->free_blocks + 8) {
if (sbi->total_blocks - sbi->free_blocks + 8 >
sbi->alloc_file->i_size * 8) {
/* extend alloc file */
printk(KERN_ERR "hfs: extend alloc file! (%Lu,%u,%u)\n",
sbi->alloc_file->i_size * 8,
sbi->total_blocks, sbi->free_blocks);
printk(KERN_ERR "hfs: extend alloc file! "
"(%llu,%u,%u)\n",
sbi->alloc_file->i_size * 8,
sbi->total_blocks, sbi->free_blocks);
return -ENOSPC;
}

Expand Down Expand Up @@ -490,8 +491,9 @@ void hfsplus_file_truncate(struct inode *inode)
u32 alloc_cnt, blk_cnt, start;
int res;

dprint(DBG_INODE, "truncate: %lu, %Lu -> %Lu\n",
inode->i_ino, (long long)hip->phys_size, inode->i_size);
dprint(DBG_INODE, "truncate: %lu, %llu -> %llu\n",
inode->i_ino, (long long)hip->phys_size,
inode->i_size);

if (inode->i_size > hip->phys_size) {
struct address_space *mapping = inode->i_mapping;
Expand Down
3 changes: 2 additions & 1 deletion fs/hfsplus/hfsplus_fs.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@
#define DBG_MASK (0)

#define dprint(flg, fmt, args...) \
if (flg & DBG_MASK) printk(fmt , ## args)
if (flg & DBG_MASK) \
printk(fmt , ## args)

/* Runtime config options */
#define HFSPLUS_DEF_CR_TYPE 0x3F3F3F3F /* '????' */
Expand Down

0 comments on commit b2837fc

Please sign in to comment.