Skip to content

Commit

Permalink
drm/i915/dram: hide the dram structs better
Browse files Browse the repository at this point in the history
Finish the job started in d28ae3b ("drm/i915: split out
intel_dram.[ch] from i915_drv.c") by moving struct dram_dimm_info and
dram_channel_info inside intel_dram.c, the only user of the structs.

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200227145359.17543-1-jani.nikula@intel.com
  • Loading branch information
Jani Nikula committed Mar 2, 2020
1 parent 0053552 commit b28bba8
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
10 changes: 0 additions & 10 deletions drivers/gpu/drm/i915/i915_drv.h
Original file line number Diff line number Diff line change
Expand Up @@ -1244,16 +1244,6 @@ struct drm_i915_private {
*/
};

struct dram_dimm_info {
u8 size, width, ranks;
};

struct dram_channel_info {
struct dram_dimm_info dimm_l, dimm_s;
u8 ranks;
bool is_16gb_dimm;
};

static inline struct drm_i915_private *to_i915(const struct drm_device *dev)
{
return container_of(dev, struct drm_i915_private, drm);
Expand Down
10 changes: 10 additions & 0 deletions drivers/gpu/drm/i915/intel_dram.c
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,16 @@
#include "i915_drv.h"
#include "intel_dram.h"

struct dram_dimm_info {
u8 size, width, ranks;
};

struct dram_channel_info {
struct dram_dimm_info dimm_l, dimm_s;
u8 ranks;
bool is_16gb_dimm;
};

#define DRAM_TYPE_STR(type) [INTEL_DRAM_ ## type] = #type

static const char *intel_dram_type_str(enum intel_dram_type type)
Expand Down

0 comments on commit b28bba8

Please sign in to comment.