Skip to content

Commit

Permalink
serial: 8250: of: Correct of_platform_serial_setup() error handling
Browse files Browse the repository at this point in the history
Don't dispose IRQ mapping before it has been created.

Fixes: aa95947 ("serial: 8250_of: Add IO space support")
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Alexander Sverdlin authored and Greg Kroah-Hartman committed Jul 16, 2018
1 parent b819e4a commit b29330d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/tty/serial/8250/8250_of.c
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ static int of_platform_serial_setup(struct platform_device *ofdev,
dev_warn(&ofdev->dev, "unsupported reg-io-width (%d)\n",
prop);
ret = -EINVAL;
goto err_dispose;
goto err_unprepare;
}
}
port->flags |= UPF_IOREMAP;
Expand Down

0 comments on commit b29330d

Please sign in to comment.