Skip to content

Commit

Permalink
interconnect: qcom: sdm845: Walk the list safely on node removal
Browse files Browse the repository at this point in the history
As we will remove items off the list using list_del(), we need to use the
safe version of list_for_each_entry().

Fixes: b5d2f74 ("interconnect: qcom: Add sdm845 interconnect provider driver")
Reported-by: Dmitry Osipenko <digetx@gmail.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
Cc: <stable@vger.kernel.org> # v5.3+
Link: https://lore.kernel.org/r/20191212075332.16202-3-georgi.djakov@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Georgi Djakov authored and Greg Kroah-Hartman committed Dec 12, 2019
1 parent e27da6a commit b29b811
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/interconnect/qcom/sdm845.c
Original file line number Diff line number Diff line change
Expand Up @@ -868,9 +868,9 @@ static int qnoc_remove(struct platform_device *pdev)
{
struct qcom_icc_provider *qp = platform_get_drvdata(pdev);
struct icc_provider *provider = &qp->provider;
struct icc_node *n;
struct icc_node *n, *tmp;

list_for_each_entry(n, &provider->nodes, node_list) {
list_for_each_entry_safe(n, tmp, &provider->nodes, node_list) {
icc_node_del(n);
icc_node_destroy(n->id);
}
Expand Down

0 comments on commit b29b811

Please sign in to comment.