Skip to content

Commit

Permalink
MIPS: Export tlbmiss_handler_setup_pgd near its definition
Browse files Browse the repository at this point in the history
We export tlbmiss_handler_setup_pgd in arch/mips/mm/tlbex.c close to a
declaration of it, rather than close to its definition as is standard.

We've supported exporting symbols in assembly code since commit
22823ab ("EXPORT_SYMBOL() for asm"), so move the export to follow
the function's (stub) definition.

Signed-off-by: Paul Burton <paul.burton@mips.com>
  • Loading branch information
Paul Burton committed Aug 11, 2018
1 parent 22f20a1 commit b29fea3
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions arch/mips/include/asm/asm-prototypes.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@
#include <asm-generic/asm-prototypes.h>
#include <linux/uaccess.h>
#include <asm/ftrace.h>
#include <asm/mmu_context.h>
2 changes: 2 additions & 0 deletions arch/mips/mm/tlb-funcs.S
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
* Copyright (C) 2012 Ralf Baechle <ralf@linux-mips.org>
*/
#include <asm/asm.h>
#include <asm/export.h>
#include <asm/regdef.h>

#define FASTPATH_SIZE 128
Expand All @@ -22,6 +23,7 @@ LEAF(tlbmiss_handler_setup_pgd)
.space 64
END(tlbmiss_handler_setup_pgd)
EXPORT(tlbmiss_handler_setup_pgd_end)
EXPORT_SYMBOL_GPL(tlbmiss_handler_setup_pgd)

LEAF(handle_tlbm)
.space FASTPATH_SIZE * 4
Expand Down
1 change: 0 additions & 1 deletion arch/mips/mm/tlbex.c
Original file line number Diff line number Diff line change
Expand Up @@ -1576,7 +1576,6 @@ extern u32 handle_tlbs[], handle_tlbs_end[];
extern u32 handle_tlbm[], handle_tlbm_end[];
extern u32 tlbmiss_handler_setup_pgd_start[];
extern u32 tlbmiss_handler_setup_pgd[];
EXPORT_SYMBOL_GPL(tlbmiss_handler_setup_pgd);
extern u32 tlbmiss_handler_setup_pgd_end[];

static void build_setup_pgd(void)
Expand Down

0 comments on commit b29fea3

Please sign in to comment.