Skip to content

Commit

Permalink
cavium: Return negative value when pci_alloc_irq_vectors() fails
Browse files Browse the repository at this point in the history
During the process of driver probing, the probe function should return < 0
for failure, otherwise, the kernel will treat value > 0 as success.

Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Zheyu Ma authored and David S. Miller committed Oct 18, 2021
1 parent d1a7b9e commit b2cddb4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/ethernet/cavium/thunder/nic_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -1193,7 +1193,7 @@ static int nic_register_interrupts(struct nicpf *nic)
dev_err(&nic->pdev->dev,
"Request for #%d msix vectors failed, returned %d\n",
nic->num_vec, ret);
return 1;
return ret;
}

/* Register mailbox interrupt handler */
Expand Down

0 comments on commit b2cddb4

Please sign in to comment.