Skip to content

Commit

Permalink
[media] tda6655: get rid of get_state()/set_state()
Browse files Browse the repository at this point in the history
Those ops aren't used by any driver, with is weird. I suspect
that mantis_vb3030 driver were not working properly...

Anyway, now that the driver uses the set_parms, the DVB
frontend core should do the right thing.

Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
  • Loading branch information
Mauro Carvalho Chehab committed Nov 17, 2015
1 parent e417668 commit b2d3afc
Showing 1 changed file with 0 additions and 36 deletions.
36 changes: 0 additions & 36 deletions drivers/media/dvb-frontends/tda665x.c
Original file line number Diff line number Diff line change
Expand Up @@ -66,28 +66,6 @@ static int tda665x_write(struct tda665x_state *state, u8 *buf, u8 length)
return err;
}

static int tda665x_get_state(struct dvb_frontend *fe,
enum tuner_param param,
struct tuner_state *tstate)
{
struct tda665x_state *state = fe->tuner_priv;
int err = 0;

switch (param) {
case DVBFE_TUNER_FREQUENCY:
tstate->frequency = state->frequency;
break;
case DVBFE_TUNER_BANDWIDTH:
break;
default:
printk(KERN_ERR "%s: Unknown parameter (param=%d)\n", __func__, param);
err = -EINVAL;
break;
}

return err;
}

static int tda665x_get_frequency(struct dvb_frontend *fe, u32 *frequency)
{
struct tda665x_state *state = fe->tuner_priv;
Expand Down Expand Up @@ -219,17 +197,6 @@ static int tda665x_set_params(struct dvb_frontend *fe)
return 0;
}

static int tda665x_set_state(struct dvb_frontend *fe,
enum tuner_param param,
struct tuner_state *tstate)
{
if (param & DVBFE_TUNER_FREQUENCY)
return tda665x_set_frequency(fe, tstate->frequency);

printk(KERN_ERR "%s: Unknown parameter (param=%d)\n", __func__, param);
return -EINVAL;
}

static int tda665x_release(struct dvb_frontend *fe)
{
struct tda665x_state *state = fe->tuner_priv;
Expand All @@ -240,9 +207,6 @@ static int tda665x_release(struct dvb_frontend *fe)
}

static struct dvb_tuner_ops tda665x_ops = {

.set_state = tda665x_set_state,
.get_state = tda665x_get_state,
.get_status = tda665x_get_status,
.set_params = tda665x_set_params,
.get_frequency = tda665x_get_frequency,
Expand Down

0 comments on commit b2d3afc

Please sign in to comment.