Skip to content

Commit

Permalink
drm/amd/display: Know what a pageflip is
Browse files Browse the repository at this point in the history
[Why]
We were assuming that any commit with allow_modeset == false
was a pageflip.  This was against drm intention and only
worked by sheer luck

[How]
A pageflip is the change from one framebuffer to another

Signed-off-by: David Francis <David.Francis@amd.com>
Reviewed-by: Harry Wentland <Harry.Wentland@amd.com>
Reviewed-by: Nicholas Kazlauskas <Nicholas.Kazlauskas@amd.com>
Acked-by: Leo Li <sunpeng.li@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
  • Loading branch information
David Francis authored and Alex Deucher committed Jan 25, 2019
1 parent bc7f670 commit b2e8530
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
Original file line number Diff line number Diff line change
Expand Up @@ -4683,7 +4683,8 @@ static void amdgpu_dm_commit_planes(struct drm_atomic_state *state,
if (!new_crtc_state->active)
continue;

pflip_needed = !state->allow_modeset;
pflip_needed = old_plane_state->fb &&
old_plane_state->fb != new_plane_state->fb;

dc_plane = dm_new_plane_state->dc_state;

Expand Down

0 comments on commit b2e8530

Please sign in to comment.