Skip to content

Commit

Permalink
drm: atmel_hldc: Use generic drm_connector_register_all() helper
Browse files Browse the repository at this point in the history
This driver used to have its own implementation of connector_register_all()
which actually was taken as a prototype of drm_connector_register_all().

Now when drm_connector_register_all() exists reusing it here.

Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: David Airlie <airlied@linux.ie>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1461068693-11260-3-git-send-email-abrodkin@synopsys.com
  • Loading branch information
Alexey Brodkin authored and Daniel Vetter committed Apr 20, 2016
1 parent 54d2c2d commit b3383f7
Showing 1 changed file with 1 addition and 29 deletions.
30 changes: 1 addition & 29 deletions drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
Original file line number Diff line number Diff line change
Expand Up @@ -584,34 +584,6 @@ static void atmel_hlcdc_dc_unload(struct drm_device *dev)
destroy_workqueue(dc->wq);
}

static int atmel_hlcdc_dc_connector_plug_all(struct drm_device *dev)
{
struct drm_connector *connector, *failed;
int ret;

mutex_lock(&dev->mode_config.mutex);
list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
ret = drm_connector_register(connector);
if (ret) {
failed = connector;
goto err;
}
}
mutex_unlock(&dev->mode_config.mutex);
return 0;

err:
list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
if (failed == connector)
break;

drm_connector_unregister(connector);
}
mutex_unlock(&dev->mode_config.mutex);

return ret;
}

static void atmel_hlcdc_dc_connector_unplug_all(struct drm_device *dev)
{
mutex_lock(&dev->mode_config.mutex);
Expand Down Expand Up @@ -736,7 +708,7 @@ static int atmel_hlcdc_dc_drm_probe(struct platform_device *pdev)
if (ret)
goto err_unload;

ret = atmel_hlcdc_dc_connector_plug_all(ddev);
ret = drm_connector_register_all(ddev);
if (ret)
goto err_unregister;

Expand Down

0 comments on commit b3383f7

Please sign in to comment.