Skip to content

Commit

Permalink
selinux: Use kmalloc_array() in sidtab_init()
Browse files Browse the repository at this point in the history
A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "kmalloc_array".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Paul Moore <paul@paul-moore.com>
  • Loading branch information
Markus Elfring authored and Paul Moore committed Mar 29, 2017
1 parent ebd2b47 commit b380f78
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion security/selinux/ss/sidtab.c
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ int sidtab_init(struct sidtab *s)
{
int i;

s->htable = kmalloc(sizeof(*(s->htable)) * SIDTAB_SIZE, GFP_ATOMIC);
s->htable = kmalloc_array(SIDTAB_SIZE, sizeof(*s->htable), GFP_ATOMIC);
if (!s->htable)
return -ENOMEM;
for (i = 0; i < SIDTAB_SIZE; i++)
Expand Down

0 comments on commit b380f78

Please sign in to comment.